Open
Conversation
Owner
|
Can you show how the player list looks like in the PR description? |
Crystalwarrior
approved these changes
Jul 21, 2024
Owner
|
actually before we merge this, we should consider the functionality of the player list as well and what it should let you do. We can actually merge down a lot of the current functionality into the player list, for example pairing and muting list could be handled from the player list. And for servers that don't support the player list packet we could have it so the list is populated with all the characters to be able to run commands like pairing/muting etc. which is the default behavior |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
["PL", ['[CHAR_ID1] "CHAR_NAME1" (CHAR_SHOWNAME1)', '[CHAR_ID2] "CHAR_NAME2" (CHAR_SHOWNAME2)']